gdm: Only disconnect verification signals when not going to retry

At the moment a failure in a background service can lead to the
various verification signals getting disconnected, even though
we still need them for a foreground service.

This commit changes the code to only disconnect when we've run
out of tries.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1821>

diff --git a/js/gdm/util.js b/js/gdm/util.js
index cb70c285f538afddbf027a9d787706a4df277c48..ecaf09b6a8c5673935fafa6cb3c1b889018f2d9f 100644 (file)
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -690,13 +690,13 @@ var ShellUserVerifier = class {
         // the dialog
         // Otherwise, when in login mode we allow ALLOWED_FAILURES attempts.
         // After that, we go back to the welcome screen.
-        this._disconnectSignals();
-
         this._filterServiceMessages(serviceName, MessageType.ERROR);
 
         const doneTrying = !shouldRetry || !this._canRetry();
 
         if (doneTrying) {
+            this._disconnectSignals();
+
             // eslint-disable-next-line no-lonely-if
             if (!this.hasPendingMessages) {
                 this._cancelAndReset();